Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] HttpRequestMessage.Headers.ExpectContinue is ignored on browser #53876

Closed
pavelsavara opened this issue Jun 8, 2021 · 2 comments · Fixed by #57058
Closed

[wasm] HttpRequestMessage.Headers.ExpectContinue is ignored on browser #53876

pavelsavara opened this issue Jun 8, 2021 · 2 comments · Fixed by #57058
Assignees
@pavelsavara
Labels
arch-wasm WebAssembly architecture area-System.Net.Http
Milestone
6.0.0

Comments

@pavelsavara
Copy link
Member

In unit test System.Net.Http.Functional.Tests.HttpClientHandler_RemoteServerTest.PostAsync_ExpectContinue_Success(expectContinue: True, version: 1.1) on WASM in Browser

Assert.Contains() Failure Not found: "Expect": "100-continue"
   at System.Net.Http.Functional.Tests.HttpClientHandler_RemoteServerTest.PostAsync_ExpectContinue_Success(Nullable`1 expectContinue, Version version)
@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-System.Net.Http labels Jun 8, 2021
@ghost
Copy link

ghost commented Jun 8, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

In unit test System.Net.Http.Functional.Tests.HttpClientHandler_RemoteServerTest.PostAsync_ExpectContinue_Success(expectContinue: True, version: 1.1) on WASM in Browser

Assert.Contains() Failure Not found: "Expect": "100-continue"
   at System.Net.Http.Functional.Tests.HttpClientHandler_RemoteServerTest.PostAsync_ExpectContinue_Success(Nullable`1 expectContinue, Version version)
Author: pavelsavara
Assignees: -
Labels:

arch-wasm, area-System.Net.Http
Milestone: -

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Jun 8, 2021
@pavelsavara pavelsavara mentioned this issue Jun 8, 2021
Merged
pavelsavara added a commit to pavelsavara/runtime that referenced this issue Jun 8, 2021
@pavelsavara
document dotnet#53876
3fdc1d9
@pavelsavara pavelsavara changed the title [wasm] HttpRequestMessage..Headers.ExpectContinue is ignored on browser [wasm] HttpRequestMessage.Headers.ExpectContinue is ignored on browser Jun 8, 2021
@lewing lewing removed the untriaged New issue has not been triaged by the area owner label Jun 8, 2021
@lewing lewing added this to the 6.0.0 milestone Jun 8, 2021
pavelsavara added a commit that referenced this issue Jun 9, 2021
@pavelsavara
[wasm][testing] hosting echo server in xharness process (#52923)
fb61be4 
- move tests to inner loop
- include echo middleware in xharness server
- improve doc
- more granular ActiveIssue #53592 for lack of TRACE
- more granular ActiveIssue #53591 for content on GET/HEAD
- more granular ActiveIssue #53874 for HttpRequestMessage.Headers.Host
- more granular ActiveIssue #53872 for NPE on System.Net.Http.BrowserHttpHandler
- more granular ActiveIssue #53876
- include middleware in Helix correlation payload
@pavelsavara pavelsavara mentioned this issue Jun 16, 2021
Merged
@pavelsavara
Copy link
Member Author

This needs browser support, so that the HTTP client would pause after headers, before sending the HTTP payload.
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Expect

But no browser does it, see
Gecko issue
Chromium issue

@pavelsavara pavelsavara mentioned this issue Aug 9, 2021
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Aug 9, 2021
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Aug 9, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pavelsavara pavelsavara

Labels
arch-wasm WebAssembly architecture area-System.Net.Http
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

[wasm] Skip tests for ExpectContinue HTTP header pavelsavara/runtime
2 participants
@lewing @pavelsavara