Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

classloader/StaticVirtualMethods/GenericContext/GenericContextTest takes very long under GC stress, times out on OSX-arm64 #104633

Open
VSadov opened this issue Jul 9, 2024 · 3 comments
Open

classloader/StaticVirtualMethods/GenericContext/GenericContextTest takes very long under GC stress, times out on OSX-arm64 #104633

VSadov opened this issue Jul 9, 2024 · 3 comments
Labels
area-TypeSystem-coreclr blocking-clean-ci-optional Blocking optional rolling runs GCStress test-failure
Milestone
Future

Comments

@VSadov
Copy link
Member

VSadov commented Jul 9, 2024 •
edited
Loading

Examples of timeout failures:

https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-103076-merge-7269229228744033b5/Loader.2.3/1/console.f932d39f.log?helixlogtype=result

https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-85694-merge-c093b64e9e7a4971aa/Loader.1.3/1/console.60c249dc.log?helixlogtype=result

https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-85694-merge-c093b64e9e7a4971aa/Loader.2.3/1/console.a7c2f169.log?helixlogtype=result

Since this is always on a different scenario, I think it is just the test takes too long on OSX-arm64 machines.
Possibly the machines are too slow and the test is too big.
(the test was mentioned before as very large and causing trouble due to size in other contexts - #92722)

If there is no something that is particularly interesting from GC stress perspective for this test, perhaps we should just do <GCStressIncompatible>true</GCStressIncompatible>
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jul 9, 2024
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Jul 9, 2024
steveisok added a commit to steveisok/runtime that referenced this issue Jul 10, 2024
@steveisok
Set GCStressIncompatible on GenericContext tests
f71076d 
As suggested in dotnet#104633, this may help in reducing test timeouts.
@steveisok steveisok mentioned this issue Jul 10, 2024
Merged
@steveisok steveisok removed the untriaged New issue has not been triaged by the area owner label Jul 10, 2024
@steveisok steveisok added this to the 9.0.0 milestone Jul 10, 2024
@vcsjones vcsjones removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jul 11, 2024
@steveisok steveisok modified the milestones: 9.0.0, Future Jul 20, 2024
@VSadov VSadov added the blocking-clean-ci-optional Blocking optional rolling runs label Jul 24, 2024
@VSadov
Copy link
Member Author

VSadov commented Jul 24, 2024

This is blocking clean gcstress runs. I think this should be fixed in 9.0

@VSadov
Copy link
Member Author

VSadov commented Jul 24, 2024

Should be fixed by #104686

@VSadov VSadov closed this as completed Jul 24, 2024
@VSadov
Copy link
Member Author

VSadov commented Jul 29, 2024 •
edited
Loading

Sadly, the test seems to keep running, taking 4+ hours on osx-arm64, and failing in every runtime-coreclr gcstress0x3-gcstress0xc run.

https://dev.azure.com/dnceng-public/public/_build?definitionId=112&_a=summary

@VSadov VSadov reopened this Jul 29, 2024
VSadov pushed a commit to VSadov/runtime that referenced this issue Jul 29, 2024
@steveisok @VSadov
Set GCStressIncompatible on GenericContext tests
78aac0c 
As suggested in dotnet#104633, this may help in reducing test timeouts.
@VSadov VSadov mentioned this issue Jul 29, 2024
Merged
VSadov added a commit that referenced this issue Jul 30, 2024
@VSadov @steveisok
Set GCStressIncompatible on GenericContext test (#105645)
ec5afb7 
* Set GCStressIncompatible on GenericContext tests

As suggested in #104633, this may help in reducing test timeouts.

* Update src/tests/Loader/classloader/StaticVirtualMethods/GenericContext/GenericContextCommonCs.csproj

Co-authored-by: Vladimir Sadov <vsadov@microsoft.com>

* Put suppression on tests exe projects, not on the common library.

---------

Co-authored-by: Steve Pfister <stpfiste@microsoft.com>
Co-authored-by: Steve Pfister <steveisok@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-TypeSystem-coreclr blocking-clean-ci-optional Blocking optional rolling runs GCStress test-failure
Projects
None yet
Milestone
Future
Development

No branches or pull requests
4 participants
@vcsjones @steveisok @VSadov @jeffschwMSFT