Skip to content

Commit

Permalink
Set SocketsHttpHandler's default connect timeout to 15s (#66607)
Browse files Browse the repository at this point in the history
* Set default connect timeout to 15s

* Fix ConnectTimeout_Default test
  • Loading branch information
CarnaViire committed Mar 15, 2022
1 parent 734362c commit 436b97c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,6 @@ internal static partial class HttpHandlerDefaults
public static readonly TimeSpan DefaultPooledConnectionLifetime = Timeout.InfiniteTimeSpan;
public static readonly TimeSpan DefaultPooledConnectionIdleTimeout = TimeSpan.FromMinutes(1);
public static readonly TimeSpan DefaultExpect100ContinueTimeout = TimeSpan.FromSeconds(1);
public static readonly TimeSpan DefaultConnectTimeout = Timeout.InfiniteTimeSpan;
public static readonly TimeSpan DefaultConnectTimeout = TimeSpan.FromSeconds(15);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -1054,7 +1054,7 @@ public void ConnectTimeout_Default()
{
using (var handler = new SocketsHttpHandler())
{
Assert.Equal(Timeout.InfiniteTimeSpan, handler.ConnectTimeout);
Assert.Equal(TimeSpan.FromSeconds(15), handler.ConnectTimeout);
}
}

Expand Down

0 comments on commit 436b97c

Please sign in to comment.