wip

dotnet · Aug 17, 2023 · 2a2ebb7 · 2a2ebb7
1 parent 7346cb2
commit 2a2ebb7
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/eng/testing/wasm-provisioning.targets b/eng/testing/wasm-provisioning.targets
@@ -7,14 +7,14 @@
 
     <ChromeOSIdentifier Condition="$([MSBuild]::IsOSPlatform('windows'))">win</ChromeOSIdentifier>
     <ChromeOSIdentifier Condition="$([MSBuild]::IsOSPlatform('linux'))">linux</ChromeOSIdentifier>
-    <ChromeOSIdentifier Condition="$([MSBuild]::IsOSPlatform('mac'))">mac</ChromeOSIdentifier>
     <ChromeOSIdentifier Condition="'$(ChromeOSIdentifier)' == ''">unsupported-platform</ChromeOSIdentifier>
 
+    <!-- disable by default on unsupported platforms -->
     <InstallChromeForTests Condition="'$(InstallChromeForTests)' == '' and '$(ChromeOSIdentifier)' == ''">false</InstallChromeForTests>
-    <!-- FIXME: warn if versions are not available -->
 
     <FirefoxDir>$(ArtifactsBinDir)firefox\</FirefoxDir>
     <FirefoxStampFile>$([MSBuild]::NormalizePath($(FirefoxDir), '.install-firefox-$(FirefoxRevision).stamp'))</FirefoxStampFile>
+    <_BrowserStampDir>$(ArtifactsBinDir)\</_BrowserStampDir>
   </PropertyGroup>
 
   <Import Project="$(MSBuildThisFileDirectory)ChromeVersions.props" />
@@ -55,9 +55,7 @@
     <ChromeDriverUrl>$(win_ChromeBaseSnapshotUrl)/chromedriver_win32.zip</ChromeDriverUrl>
   </PropertyGroup>
 
-  <PropertyGroup>
-    <_BrowserStampDir>$(ArtifactsBinDir)\</_BrowserStampDir>
-
+  <PropertyGroup Condition="'$(ChromeVersion)' != ''">
     <ChromeDir>$(ArtifactsBinDir)chrome\</ChromeDir>
     <ChromeDriverDir>$(ArtifactsBinDir)chromedriver\</ChromeDriverDir>
     <ChromeStampFile>$([MSBuild]::NormalizePath('$(ChromeDir)', '.install-$(ChromeVersion)-$(ChromeRevision).stamp'))</ChromeStampFile>