Do not offer 'convert' namespace when the ns has sibling types #74216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
commented
Jun 29, 2024
| { | ||
| } | ||
| "; | ||
| var code = """ |
There was a problem hiding this comment.
just converting to raw srtings.
CyrusNajmabadi
commented
Jun 29, 2024
| @@ -61,6 +62,9 @@ public Test() | |||
| /// <inheritdoc cref="SharedVerifierState.Options"/> | |||
| internal OptionsCollection Options => _sharedState.Options; | |||
|
|
|||
| [StringSyntax("C#-Test")] public new string TestCode { set => base.TestCode = value; } | |||
| [StringSyntax("C#-Test")] public new string FixedCode { set => base.FixedCode = value; } | |||
There was a problem hiding this comment.
allows syntax highlighting of test code.
CyrusNajmabadi
commented
Jun 29, 2024
| @@ -244,6 +244,7 @@ | |||
| <Compile Include="$(MSBuildThisFileDirectory)EmbeddedLanguages\Common\EmbeddedSyntaxToken.cs" /> | |||
| <Compile Include="$(MSBuildThisFileDirectory)EmbeddedLanguages\Common\EmbeddedSyntaxTree.cs" /> | |||
| <Compile Include="$(MSBuildThisFileDirectory)EmbeddedLanguages\Common\EmbeddedSyntaxTrivia.cs" /> | |||
| <Compile Include="$(MSBuildThisFileDirectory)EmbeddedLanguages\PredefinedEmbeddedLanguageClassifierNames.cs" /> | |||
There was a problem hiding this comment.
moved to shared file so we can reference the "CSharpTest" constant in the test files.
3 tasks
ToddGrun
approved these changes
Jul 1, 2024
| internal class ConvertNamespaceCodeRefactoringProvider : SyntaxEditorBasedCodeRefactoringProvider | ||
| [method: ImportingConstructor] | ||
| [method: SuppressMessage("RoslynDiagnosticsReliability", "RS0033:Importing constructor should be [Obsolete]", Justification = "Used in test code: https://github.com/dotnet/roslyn/issues/42814")] | ||
| internal class ConvertNamespaceCodeRefactoringProvider() : SyntaxEditorBasedCodeRefactoringProvider |
akhera99
approved these changes
Jul 1, 2024
This was referenced Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #74214