Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache the last string's hash we computed in our filepath map #73937

Merged
merged 4 commits into from
Jun 11, 2024

Conversation

CyrusNajmabadi
Copy link
Member

Drops CPU cost in VS during solution load from:

image

to

image

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner June 11, 2024 15:17
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Jun 11, 2024
@CyrusNajmabadi
Copy link
Member Author

@ToddGrun ptal.

_lock.Exit();
}

if (ReferenceEquals(lastString, obj))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if (ReferenceEquals(lastString, obj))

Would it make things ugly to check _lastString against obj and only taking the lock if ReferenceEqual?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants