Throw when there is a syntax version mismatch in codelens #73902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt will re-request
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
sharwell
reviewed
Jun 10, 2024
src/LanguageServer/Protocol/Handler/CodeLens/CodeLensResolveHandler.cs
Outdated
Show resolved
Hide resolved
…ndler.cs Co-authored-by: Sam Harwell <sam@tunnelvisionlabs.com>
CyrusNajmabadi
approved these changes
Jun 10, 2024
Open
3 tasks
This was referenced Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed in integration tests that sometimes we would get silent failures. We should be throwing here with a specific exception that will tell the client to re-request the codelens items.
This also matches how inlay hints behaves.