Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow use of more Hot Reload brokered services by LSP (for VS Code) #73240

Merged

Conversation

BretJohnson
Copy link
Member

@BretJohnson BretJohnson commented Apr 26, 2024

Add the HotReloadOptionService and HotReloadLoggerService to the list of remote brokered services that are registered, allowing use of those services by MAUI Hot Reload in VS Code. Both of these Hot Reload services are proffered by vs-green debugger functionality, implemented in TypeScript there.

These changes need to be in VS Code before the functionality here
https://devdiv.visualstudio.com/DevDiv/_git/VS/pullrequest/546989,
that depends on them, can work.

@BretJohnson BretJohnson requested a review from a team as a code owner April 26, 2024 00:17
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Apr 26, 2024
@dotnet-policy-service dotnet-policy-service bot added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label Apr 26, 2024
Add the HotReloadOptionService and HotReloadLoggerService to the list
of remote brokered services that are registered, allowing use of those
services by MAUI Hot Reload in VS Code. Both of these Hot Reload
services are proffered by vs-green debugger functionality, implemented
in TypeScript there.
@BretJohnson BretJohnson force-pushed the dev/bretjohn/include-more-brokered-services branch from c287963 to a0375ce Compare April 26, 2024 00:20
@BretJohnson
Copy link
Member Author

cc @dibarbet

@BretJohnson
Copy link
Member Author

@CyrusNajmabadi - do you want to review as well? should be quick; thanks

@dibarbet dibarbet merged commit 39b5d9d into dotnet:main Apr 29, 2024
25 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Apr 29, 2024
@dibarbet dibarbet modified the milestones: Next, 17.11 P1 Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee. untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants