Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for deconstruction and discards #16643

Merged
merged 5 commits into from
Jan 24, 2017
Merged

Conversation

jcouv
Copy link
Member

@jcouv jcouv commented Jan 20, 2017

This is a doc and test-only change.

Fixes #16190
Contributes to #14832

@gafter for review, no rush (post-dev15 branch).

@jcouv jcouv added Area-Compilers Documentation Test Test failures in roslyn-CI labels Jan 20, 2017
@jcouv jcouv added this to the 2.1 milestone Jan 20, 2017
@jcouv jcouv self-assigned this Jan 20, 2017
@jcouv jcouv requested a review from gafter January 23, 2017 23:00
;
expression
: ... // existing
| declaration_expression // new
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should probably add some text explaining that a declaration expression is only permitted in specific designated syntactic positions.

Copy link
Member

@gafter gafter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gafter gafter removed their assignment Jan 23, 2017
@jcouv
Copy link
Member Author

jcouv commented Jan 24, 2017

Merging doc- and test- only change with single code review.
FYI @dotnet/roslyn-compiler

@jcouv jcouv merged commit f109e5d into dotnet:post-dev15 Jan 24, 2017
@jcouv jcouv deleted the update-docs branch January 24, 2017 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants