Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/9.0.1xx] Update dependencies from dotnet/arcade #7386

Conversation

dotnet-maestro[bot]
Copy link
Contributor

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

  • Subscription: f77a629d-fa07-48ec-500a-08dcbc3022d8
  • Build: 20240821.2
  • Date Produced: August 21, 2024 9:36:39 AM UTC
  • Commit: 9b24668b7196b9639e60770465683cf81465d89a
  • Branch: refs/heads/main
  • Updates to .NET SDKs:
    • Updates sdk.version to 9.0.100-preview.7.24407.12
    • Updates tools.dotnet to 9.0.100-preview.7.24407.12

…821.2

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XliffTasks
 From Version 9.0.0-beta.24272.5 -> To Version 9.0.0-beta.24421.2
@dotnet-maestro dotnet-maestro bot requested a review from a team as a code owner August 21, 2024 18:21
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR changes the .NET SDK version. Review required from @dotnet/roslyn-infrastructure-current-swat before merging.

Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming the CI passes, we need to merge this.

@carlossanlop
Copy link
Member

Either I get added to https://github.com/orgs/dotnet/teams/roslyn-infrastructure-current-swat or we get a sign-off from one of the members (@sharwell or @jaredpar?)

@jaredpar
Copy link
Member

@arkalyanms

@carlossanlop
Copy link
Member

@dotnet/roslyn-infrastructure-current-swat I opened a PR against main to address the CI failures: #7387

and I cherry-picked that commit into this PR: 4d3ab63

I opened an issue to keep track of this workaround to eventually replace it to the new correct code: #7388

@carlossanlop
Copy link
Member

The CI is frozen waiting. Closing and reopening, see if that triggers it.

@carlossanlop carlossanlop reopened this Aug 21, 2024
@carlossanlop carlossanlop enabled auto-merge (squash) August 21, 2024 19:59
@carlossanlop
Copy link
Member

There are two more, same error. They got uncovered after fixing the other ones. Strangely I didn't see them in my local build. Fixing now, and will include them in the main PR too.

@carlossanlop carlossanlop enabled auto-merge (squash) August 21, 2024 20:31
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.49%. Comparing base (fdb9965) to head (f3addd1).
Report is 1 commits behind head on release/9.0.1xx.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           release/9.0.1xx    #7386      +/-   ##
===================================================
- Coverage            96.49%   96.49%   -0.01%     
===================================================
  Files                 1443     1443              
  Lines               345885   345885              
  Branches             11374    11374              
===================================================
- Hits                333767   333766       -1     
- Misses                9236     9237       +1     
  Partials              2882     2882              

@carlossanlop carlossanlop dismissed GitHub Actions’s stale review August 21, 2024 21:08

Signed off and CI passed

@carlossanlop carlossanlop merged commit 930872a into release/9.0.1xx Aug 21, 2024
11 checks passed
@carlossanlop carlossanlop deleted the darc-release/9.0.1xx-96dcf6a1-c3d9-4aaa-97bb-776586ad00e0 branch August 21, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants