Execute NameAndParametersValid only when needed. #7353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The NameAndParametersValid is executed for ALL methods in a class, independenlty of the methods being static and returning a boolean. If you look carefully at the code, we have a || after a && therefore the NamedAndParametersValid is executed ALWAYS. This means that we are performing the check for EVEVERY method, rather than on those methods that are static and return a bool.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7353 +/- ##
=======================================
Coverage 96.49% 96.49%
=======================================
Files 1443 1443
Lines 345799 345799
Branches 11374 11374
=======================================
+ Hits 333665 333670 +5
+ Misses 9251 9245 -6
- Partials 2883 2884 +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NameAndParametersValid is executed for ALL methods in a class, independently of the methods being static and returning a boolean.
If you look carefully at the code, we have a || after a && therefore the NamedAndParametersValid is executed ALWAYS. This means that we are performing the check for EVEVERY method, rather than on those methods that are static and return a bool.