CA2022: Do not flag well known reliable stream types

[mpidash]

Fixes #7268.

I only excluded exact type matches of known reliable stream types (i.e. instances of System.IO.MemoryStream or System.IO.UnmanagedMemoryStream).
Let me know if we want to exclude child classes as well, but it seems based on the comment in the issue (#7268 (comment)) that this could lead to false negatives.

We could detect more cases with flow analysis, but this would mean that the rule is disabled by default (AFAIK).

cc @buyaa-n @stephentoub

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.48%. Comparing base (0868ca2) to head (d454355).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7269      +/-   ##
==========================================
- Coverage   96.48%   96.48%   -0.01%     
==========================================
  Files        1442     1442              
  Lines      345212   345257      +45     
  Branches    11345    11346       +1     
==========================================
+ Hits       333081   333120      +39     
- Misses       9256     9263       +7     
+ Partials     2875     2874       -1     

[buyaa-n]

Let me know if we want to exclude child classes as well, but it seems based on the comment in the issue (#7268 (comment)) that this could lead to false negatives.

Based on that comment I would say no, but as the Stream or MemoryStream are not sealed we might want to make it configurable: https://github.com/dotnet/roslyn-analyzers/blob/main/docs/Analyzer%20Configuration.md#excluded-symbols what you think @mpidash @stephentoub?

[buyaa-n]

The fix LGTM, thank you, I'll wait for opinions for the open question for making it configurable

[stephentoub]

Let me know if we want to exclude child classes as well, but it seems based on the comment in the issue (#7268 (comment)) that this could lead to false negatives.

Based on that comment I would say no, but as the Stream or MemoryStream are not sealed we might want to make it configurable: https://github.com/dotnet/roslyn-analyzers/blob/main/docs/Analyzer%20Configuration.md#excluded-symbols what you think @mpidash @stephentoub?

We could, but I'd be fine waiting until we have real user cases for it. MemoryStream is one that comes up a lot, especially in tests, and so it's worth reducing noise about.

[buyaa-n]

Good point, thanks!

[drewnoakes]

Can the set be created with this comparer so the lookup is O(1) rather than O(N)?