Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set ProducesDotNetReleaseShippingAssets property in Publishing.props #7206

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

MilenaHristova
Copy link
Member

Add a boolean property named ProducesDotNetReleaseShippingAssets in Publishing.props for repos that produce .NET shipping packages (packages that we ship with the release infra)
Based on this property we will select which packages to ship as part of .NET on release day.

This is a infrastructure only change. It will add extra metadata to the MergedManifest.xml produced during CI build.

Issue: https://github.com/dotnet/release/issues/822

@MilenaHristova MilenaHristova requested a review from a team as a code owner February 21, 2024 11:35
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ab13ac7) 96.45% compared to head (34df03e) 96.45%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7206   +/-   ##
=======================================
  Coverage   96.45%   96.45%           
=======================================
  Files        1422     1422           
  Lines      340585   340585           
  Branches    11230    11230           
=======================================
+ Hits       328511   328520    +9     
+ Misses       9236     9227    -9     
  Partials     2838     2838           

Copy link
Member

@buyaa-n buyaa-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IDK what it does, but approving and merging as @ericstj approved.

@buyaa-n buyaa-n merged commit a9b6a93 into dotnet:main Feb 22, 2024
14 checks passed
@ericstj
Copy link
Member

ericstj commented Feb 22, 2024

Per the linked issue above - it's a property being set in all shipping repos.

@MilenaHristova MilenaHristova deleted the publishing-props branch February 27, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants