Publish rzls as a nuget package for vs-code #10453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryzngard
commented
Jun 6, 2024
ryzngard
commented
Jun 6, 2024
davidwengier
reviewed
Jun 6, 2024
src/Razor/src/Microsoft.VisualStudio.DevKit.Razor/Microsoft.VisualStudio.DevKit.Razor.csproj
Show resolved
Hide resolved
src/Razor/src/Microsoft.VisualStudio.DevKit.Razor/Microsoft.VisualStudio.DevKit.Razor.csproj
Outdated
Show resolved
Hide resolved
|
I've validated locally with downloaded packages from this test insertion https://dev.azure.com/dnceng/internal/_build/results?buildId=2470510&view=artifacts&pathAsName=false&type=publishedArtifacts @DustinCampbell @davidwengier let me know if there's anything else blocking! Everything looks to be working for rzls with some changes in vscode (I'll link PR in a moment when I get it) |
davidwengier
approved these changes
Jun 11, 2024
I guess we'll see! |
This was referenced Jun 13, 2024
|
There is some fallout in dotnet/sdk#41536 |
davidwengier
added a commit
that referenced
this pull request
Jun 25, 2024
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2088486 Seems this was inadvertently removed in #10453 @ryzngard I'm pretty out of my depth here about what is required, but a local build of rzls with this change does fix the problem. Are there any other project properties that might be important, that I should bring back?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The majority of this was just copied from the way Roslyn packages their language server. Will do a test insertion to see if packages are actually published to vs-impl and can be consumed in vs-code before merging