Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Project Properties UI for NuGet Audit settings #9538

Merged
merged 3 commits into from
Sep 23, 2024
Merged

Add Project Properties UI for NuGet Audit settings #9538

merged 3 commits into from
Sep 23, 2024

Conversation

drewnoakes
Copy link
Member

@drewnoakes drewnoakes commented Sep 23, 2024 •
edited
Loading

Fixes #9246

Adds definitions for three properties that control how NuGet Audit is presented to the user, allowing them to configure the feature to their liking.

image

@drewnoakes
Add Project Properties UI for NuGet Audit settings
abc67be 
Adds definitions for three properties that control how NuGet Audit is
presented to the user, allowing them to configure the feature to their
liking.
@drewnoakes drewnoakes added Feature-NuGet NuGet integration including pushing it properties, project and package references, and Pack support. Feature-Rules/Properties Feature-Project-Properties-Designer The new project property pages which replace the legacy AppDesigner labels Sep 23, 2024
@drewnoakes drewnoakes added this to the 17.12 milestone Sep 23, 2024
@drewnoakes drewnoakes requested a review from a team as a code owner September 23, 2024 11:01
@dotnet-policy-service dotnet-policy-service bot added the Feature Request Request for a new feature, or new scenario to be handled. label Sep 23, 2024
@drewnoakes
Copy link
Member Author

Updated text on audit level UI to:

image

@drewnoakes drewnoakes merged commit 9e618da into dotnet:main Sep 23, 2024
5 checks passed
@drewnoakes drewnoakes deleted the nuget-audit-properties branch September 23, 2024 13:10
tmeschter
tmeschter reviewed Sep 23, 2024
View reviewed changes
Copy link
Contributor

@tmeschter tmeschter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmeschter tmeschter tmeschter left review comments

@zivkan zivkan zivkan approved these changes

Assignees
No one assigned
Labels
Feature Request Request for a new feature, or new scenario to be handled. Feature-NuGet NuGet integration including pushing it properties, project and package references, and Pack support. Feature-Project-Properties-Designer The new project property pages which replace the legacy AppDesigner Feature-Rules/Properties
Projects
None yet
Milestone
17.12
Development

Successfully merging this pull request may close these issues.

Add project properties for NuGetAudit
3 participants
@drewnoakes @zivkan @tmeschter