Mark IsExternalInit as private assets

[smitpatel]

Moving to CPVM requires that extra properties specified on actual package reference now

This package ended up in our package and is blocking our VS insertion because we are using newer version.

Microsoft Reviewers: Open in CodeFlow

[drewnoakes]

This package ended up in our package and is blocking our VS insertion because we are using newer version.

Which package? We have units tests that validate the files in our package. Maybe those tests aren't working, or something else was going on.

[smitpatel]

"IsExternalInit" package 😄

[smitpatel]

Would you expect the missing private assets to be caught by tests? I can look into tests to see what is going on.

[drewnoakes]

This package ended up in our package

"IsExternalInit" package 😄

Sorry I meant which VSIX package (the second kind of package you mentioned). If the file was in the VSIX (which is just a ZIP file) then I would expect any change there (either adding it or removing it) to break a unit test.

Check PackageContentTests and the *.verified.txt files here:

https://github.com/dotnet/project-system/tree/main/tests/Microsoft.VisualStudio.ProjectSystem.Managed.VS.UnitTests/Setup

[drewnoakes]

Ah, I see that the IsExternalInit pacakge is a source-only package.

https://github.com/manuelroemer/IsExternalInit/blob/master/src/IsExternalInit.nuspec

This means that someone else is also incorrectly declaring it as a (non-private) dependency.