Introduce Versions.props file to control version of CPS packages #9125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
force-pushed
the
smit/UpgradeVersion
branch
4 times, most recently
from
d432cf8
to
f8753ca
Compare
This file will be used alongwith built version of project-system in C# dev kit for version upgrades
smitpatel
force-pushed
the
smit/UpgradeVersion
branch
from
f8753ca
to
7152a82
Compare
|
Requires https://devdiv.visualstudio.com/DevDiv/_git/dotnet-project-system-vscode/pullrequest/481012 to be merged first. |
adamint
reviewed
Jun 28, 2023
| <!-- Any changes to this file or format requires updates in project-system-vscode --> | ||
| <Project> | ||
| <PropertyGroup> | ||
| <CPSPackageVersion>17.7.294-pre</CPSPackageVersion> |
There was a problem hiding this comment.
Why is this here and not in any of the other props files?
There was a problem hiding this comment.
This file is used in project-system-vscode which adds element for PS.Managed version into it and uses it in other repo. It is separate since it is being used by automation. We can add more items to this file but to keep automation simple, a simple separate file like this is needed.
adamint
approved these changes
Jun 28, 2023
ghost
added this to the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This file will be used alongwith built version of project-system in C# dev kit for version upgrades
Microsoft Reviewers: Open in CodeFlow