MessagePack codec #8546
Merged
MessagePack codec #8546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@n-sidorov when you get a chance, please agree to the CLA above. |
ReubenBond
force-pushed
the
feature/nsidorov/msgpackcodec
branch
from
24bd11a
to
30ee6cf
Compare
|
👀 |
ReubenBond
force-pushed
the
feature/nsidorov/msgpackcodec
branch
from
4d22b4f
to
09168e9
Compare
ReubenBond
approved these changes
Jul 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds ability to use MessagePack serialization with either MessagePack-specific marked contracts or using DataContract attributes (requires explicit opt-in).
NOTE: quick benchmarking showed that this performs worse than both default Orleans serializer and default MessagePack serializer (since there is more "boilerplate" code required to integrate Orleans <-> MessagePack) so I've put a note in the comments.
Microsoft Reviewers: Open in CodeFlow