Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package update and central management #252

Conversation

chr-ber
Copy link
Contributor

@chr-ber chr-ber commented Jan 18, 2024

This pull request includes:

  • Moving nuget package version to a centralized place -> Directory.Packages.props
  • Updating nuget package to their latest version

@chr-ber
Copy link
Contributor Author

chr-ber commented Jan 18, 2024

@dotnet-policy-service agree

@bruno-garcia
Copy link
Member

Nice! Thanks @chr-ber

@bruno-garcia
Copy link
Member

Dang didn't recognize you from the pic Chris! ;) this makes things a lot easier to manage packages, thanks

<PackageVersion Include="NuGet.Protocol" Version="6.8.0" />
<PackageVersion Include="RabbitMQ.Client" Version="6.8.1" />
<PackageVersion Include="Sentry" Version="4.0.0-beta.4" />
<PackageVersion Include="Sentry.AspNetCore" Version="$(SentryVersion)" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually it would be nice to pull the property that sets this value also to this file. I believe it's set on a Directory.Build.props right now

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bruno-garcia added a commit, all sentry versions should now be taken from the variable in Directory.Build.props

@bruno-garcia
Copy link
Member

CI failed with

Error: src/app/app.module.ts:46:9 - error TS2322: Type '{ canvas: { fps: number; quality: number; manager: (options: PublicGetCanvasManagerOptions) => CanvasManagerInterface; }; }' is not assignable to type 'Partial<{ captureExceptions: boolean; traceInternals: boolean; }>'.
  Object literal may only specify known properties, and 'canvas' does not exist in type 'Partial<{ captureExceptions: boolean; traceInternals: boolean; }>'.

 46         canvas: {
            ~~~~~~~~~
 47           fps: 4,
    ~~~~~~~~~~~~~~~~~
... 
 49           manager: getCanvasManager,
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 50         },
    ~~~~~~~~~

We changed some canvas stuff on the Sentry SDK but surprised this happened in CI since it should be pinned to the latest version.

I'll fix it on another PR

@bruno-garcia bruno-garcia changed the title Feature/package update and central management package update and central management Jan 26, 2024
@bruno-garcia bruno-garcia merged commit c94f1a1 into dotnet:main Feb 2, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants