Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added task assembly location to TaskStartedEventArgs #9948

Merged
merged 20 commits into from
Apr 19, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Build/BackEnd/TaskExecutionHost/TaskExecutionHost.cs
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,8 @@ public bool InitializeForBatch(TaskLoggingContext loggingContext, ItemBucket bat
return false;
}

if (TaskInstance.GetType().Assembly.Location != _taskFactoryWrapper.TaskFactoryLoadedType.Path)
if (!string.IsNullOrWhiteSpace(TaskInstance.GetType().Assembly.Location) &&
TaskInstance.GetType().Assembly.Location != _taskFactoryWrapper.TaskFactoryLoadedType.Path)
MichalPavlik marked this conversation as resolved.
Show resolved Hide resolved
{
_taskLoggingContext.LogComment(MessageImportance.Normal, "TaskAssemblyLocationMismatch", TaskInstance.GetType().Assembly.Location, _taskFactoryWrapper.TaskFactoryLoadedType.Path);
}
Expand Down