Make analyzer test use bootstrap properly #9733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanKrivanek
added a commit
that referenced
this pull request
Feb 20, 2024
JanKrivanek
added a commit
that referenced
this pull request
Apr 15, 2024
* Initial demonstration version * Make analyzer test use bootstrap properly (#9733) * Hook analyzers stats stub * Fix unit tests by explicitly opting into analysis * Disable build acceleration for MSBuild.Bootstrap * Make EndToEndTests disposable * Support running Analyzers.UnitTests from stage1 * Fix MSBuild.dll casing * Don't run netfx Analyzer.UnitTests in Windows Core builds * Fix Analyzers.UnitTests on Mac * Renaming changes * Renaming for clarity (#9754) * Removing unnecessary types * Code move * Adjust namespaces * Simplify TestEnvironments in EndToEndTests * Support for per-project configuration, Acquisition mounting, etc * Add more comments * Grace handle double initialization attempts * Fix tests * Troubleshoot test, comment * Reflect PR comments * Fix build * Fix build - proper multitargeting on core builds * Adjust API naming and exposure * Add forgotten acquisition data sending * Renaming BuildCop to BuildCheck (#9893) We decided to rename the analyzer project from BuildCop to BuildCheck. This PR is just reflecting that on the code. * Renamed a few files missed (#9900) * Add template for custom analyzers (#9789) * Run tests against just-built bootstrap environment * Reflecting PR comments * Add test without analysis * Rename tests project * Force case renaming * Simplify GlobalInstance initialization * Remove multiple registrations checking * Reflect on PR feedback * Apply suggestions from code review Co-authored-by: Mariana Dematte <magarces@microsoft.com> * Reflect on PR comments * Update src/Build/BuildCheck/API/BuildAnalyzerRule.cs Co-authored-by: Farhad Alizada <104755925+f-alizada@users.noreply.github.com> * Reflect PR comments --------- Co-authored-by: Ladi Prosek <laprosek@microsoft.com> Co-authored-by: Mariana Dematte <magarces@microsoft.com> Co-authored-by: YuliiaKovalova <95473390+YuliiaKovalova@users.noreply.github.com> Co-authored-by: Farhad Alizada <104755925+f-alizada@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9729
Context
MSBuild bootstrap location should be properly injected into tests - paasing the info from msbuild properties
Extracted the Analyzers unit tests into separate assembly and made it dependent on bootstrap project