-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove trailing whitespace #9396
The head ref may contain hidden characters: "\u{1F525}trailing-whitespace\u{1F525}"
Remove trailing whitespace #9396
Conversation
Find and replace `\s+$` in `{*.cs,*.props,*.targets}`, then reverted `src/Build.OM.UnitTests/Construction/WhiteSpacePreservation_Tests.cs` since it was explicitly working with whitespace.
These were basically already manual verification-against-last-known-good, let's formalize that.
|
Yeah I did that more at first but it changed a bunch of in-the-line spaces and that's not what's been annoying me :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
I mostly ignored the first commit though
For now point to a couple of whitespace-only changes.
Conflicts: src/Tasks.UnitTests/Exec_Tests.cs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of these were in Deprecated. I'd kinda expected you'd just touch real code, but I don't really mind.
It's been driving me up the wall that half the time I or anyone else edits in an editor that respects
.editorconfig
we wind up with a bunch of irrelevant trailing-whitespace deletions. So let's just do all the deletions!Find and replace
\s+$
in{*.cs,*.props,*.targets}
, then revertedsrc/Build.OM.UnitTests/Construction/WhiteSpacePreservation_Tests.cs
since it was explicitly working with whitespace.