Cache SDK resolver data process-wide #9335
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9302
Context
Unless a shared evaluation context is used, each project evaluation creates a fresh new
SdkResolverLoader
, walks the disk to discover resolver manifests, callsAssembly.LoadFrom
on resolver assemblies and so on. The cost of this is non-trivial (close to 3% of total evaluation time for solution like OrchardCore) while arguably there is no way how any of this can change while an MSBuild process is running.Changes Made
IList<>
toIReadOnlyList<>
to codify the fact that they are immutable.CachingSdkResolverLoader
as a subclass ofSdkResolverLoader
and plugged it intoSdkResolverService
.Testing
Existing unit test and an experimental VS insertion.
Notes
Consider reviewing commit by commit.