Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention 'Shouldly' in our developer documentation #9399

Closed
baronfel opened this issue Nov 6, 2023 · 0 comments · Fixed by #9437
Closed

Mention 'Shouldly' in our developer documentation #9399

baronfel opened this issue Nov 6, 2023 · 0 comments · Fixed by #9437
Assignees
@f-alizada
Labels
iteration:2023November triaged

Comments

@baronfel
Copy link
Member

baronfel commented Nov 6, 2023 

          Thank you for the review! I have addressed the comment.

Will it make sense to mentioned 'using Shouldly' in the documentation: https://github.com/dotnet/msbuild/blob/main/documentation/wiki/Contributing-Code.md as one of the bullet points within the scope of this PR?

Originally posted by @f-alizada in #9392 (comment)
@f-alizada f-alizada mentioned this issue Nov 20, 2023
Merged
JaynieBai pushed a commit that referenced this issue Nov 27, 2023
@f-alizada
Mention preference of using Shouldly in tests (#9437)
31108ed 
Fixes #9399

Context
From the PR review there were a mention of using the Shouldly for assertions, however it was not documented at that time.

Changes Made
Update contributing code file with mentioning preference of using Shouldly in tests
@AR-May AR-May added the triaged label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@f-alizada f-alizada

Labels
iteration:2023November triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Mention preference of using Shouldly in tests f-alizada/msbuild
3 participants
@baronfel @AR-May @f-alizada