Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Essentials] Geolocation foreground listening #9572

Merged
merged 23 commits into from
Feb 13, 2023
Merged

[Essentials] Geolocation foreground listening #9572

merged 23 commits into from
Feb 13, 2023

Commits on Jan 22, 2023

  1. added geolocation foreground listening public API without implementation

    @vividos
    vividos committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    63e5c21 View commit details
    Browse the repository at this point in the history

  2. added section on geolocation sample page for foreground listening fea… 

    …ture
    @vividos
    vividos committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    6b94c1c View commit details
    Browse the repository at this point in the history

  3. implemented geolocation foreground listening for Android, iOS, MacOS … 

    …and UWP
    @vividos
    vividos committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    c350b77 View commit details
    Browse the repository at this point in the history

  4. moved common code for determining DesiredAccuracy on UWP to extension… 

    … method
    @vividos
    vividos committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    478c172 View commit details
    Browse the repository at this point in the history

  5. renamed class ListeningRequest to GeolocationListeningRequest

    @vividos
    vividos committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    95acfd8 View commit details
    Browse the repository at this point in the history

  6. renamed property IsListening to IsListeningForeground

    @vividos
    vividos committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    a21d39f View commit details
    Browse the repository at this point in the history

  7. added xml documentation for all new public methods and properties

    @vividos
    vividos committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    1adefda View commit details
    Browse the repository at this point in the history

  8. implemented event LocationError, using enum GeolocationError and clas… 

    …s GeolocationErrorEventArgs
    @vividos
    vividos committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    25f81c3 View commit details
    Browse the repository at this point in the history

  9. fixed potential leak where ContinuousLocationListener keeps the refer… 

    …ence to the GeolocationImplementation on iOS
    @vividos
    vividos committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    90ac7d5 View commit details
    Browse the repository at this point in the history

  10. changed StopListeningForegroundAsync() to StopListeningForeground() a… 

    …nd return void
    @vividos
    vividos committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    e44a8bc View commit details
    Browse the repository at this point in the history

  11. fixed error in Essentials samples where async keyword is not necessar… 

    …y anymore
    @vividos
    vividos committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    2c5448f View commit details
    Browse the repository at this point in the history

  12. enabled nullable checks for GeolocationListeningRequest class

    @vividos
    vividos committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    cdb1003 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2023

  1. renamed ListeningRequest.ios.macos.cs to match class name; no source … 

    …code changes
    @vividos
    vividos committed Jan 28, 2023
    Configuration menu
    Copy the full SHA
    06062db View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2023

  1. call StopListeningForeground() on Android, iOS and macOS before signa… 

    …lling LocationError event, to make behavior consistent with Windows
    @vividos
    vividos committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    549269c View commit details
    Browse the repository at this point in the history

  2. replaced throwing ArgumentNullException with ArgumentNullException.Th… 

    …rowIfNull()
    @vividos
    vividos committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    b737cc9 View commit details
    Browse the repository at this point in the history

  3. added xml documentation for all newly added public geolocaion foregro… 

    …und listening APIs
    @vividos
    vividos committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    ef775d2 View commit details
    Browse the repository at this point in the history

  4. removed duplicated code for determining GeolocationAccuracy on iOS an… 

    …d macOS
    @vividos
    vividos committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    187f45d View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2023

  1. renamed event LocationError to ListeningFailed and GeolocationErrorEv… 

    …entArgs to GeolocationListeningFailedEventArgs
    @vividos
    vividos committed Feb 4, 2023
    Configuration menu
    Copy the full SHA
    f4b4637 View commit details
    Browse the repository at this point in the history

  2. fixed IsListeningForeground property on Windows

    @vividos
    vividos committed Feb 4, 2023
    Configuration menu
    Copy the full SHA
    51ebc87 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2023

  1. Merge branch 'main' into geolocation-foreground-listener

    @jfversluis
    jfversluis authored Feb 13, 2023
    Configuration menu
    Copy the full SHA
    6f0ff82 View commit details
    Browse the repository at this point in the history

  2. Fixed naming

    @jfversluis
    jfversluis committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    9dd72a2 View commit details
    Browse the repository at this point in the history

  3. Update GeolocationViewModel.cs

    @jfversluis
    jfversluis committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    6ed2ac7 View commit details
    Browse the repository at this point in the history

  4. Thank you for your pull request. We are auto-formating your source co… 

    …de to follow our code guidelines.
    GitHub Actions Autoformatter committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    35fdb18 View commit details
    Browse the repository at this point in the history