Add new .NET 9 NativeAOT runtime pack RIDs #18121
Conversation
| browser-wasm; | ||
| wasi-wasm; |
There was a problem hiding this comment.
I assume that these two could be a bit controversial. There are no official runtime packs for these two RIDs and they are only relevant for the NativeAOT/LLVM experiment in the dotnet/runtimelab repository.
However, moving fully to the runtime pack approach in .NET 9 would mean that NativeAOT/LLVM has to adapt. It's non-trivial to update the supported RID list from MSBuild in an efficient way since it requires to be done early in the restore process (ie. one cannot make a NuGet that adds browser-wasm to the list).
When doing NativeAOT publish with a RID not on this list the runtime pack is silently not downloaded and resolved, resulting in a build with no runtime libraries and bogus errors later on. There's no explicit check for this case and no user friendly error. On the other hand, with a RID on this list that has no corresponding NuGet package you get a fairly meaningful error about the NuGet package not being found.
There was a problem hiding this comment.
On the other hand, with a RID on this list that has no corresponding NuGet package you get a fairly meaningful error about the NuGet package not being found.
Yes I agree that is much better.
|
/cc: @maraf |
Contributes to dotnet/runtime#87060