Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused useSyntaxTreeCache option #17768

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Remove unused useSyntaxTreeCache option #17768

wants to merge 4 commits into from

Conversation

majocha
Copy link
Contributor

@majocha majocha commented Sep 20, 2024

Clean up.
This functionality is no longer configurable, and that cache no longer exists as a separate value in the builder.
Instead SyntaxTree caching occurs naturally by preserving GraphNode computed values, IIRC.

@majocha majocha requested a review from a team as a code owner September 20, 2024 07:48
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 20, 2024 •
edited
Loading

❗ Release notes required

✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/9.0.200.md
vsintegration/src docs/release-notes/.VisualStudio/17.12.md

@psfinaki
Copy link
Member

I think surface area will need an update as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
F# Compiler and Tooling
Status: New
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@majocha @psfinaki