Make ColumnType return the mapped store type even when not set explicitly #8605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
reviewed
May 26, 2017
| { | ||
| foreach (var property in modelBuilder.Metadata.GetEntityTypes().SelectMany(e => e.GetDeclaredProperties())) | ||
| { | ||
| new InternalPropertyBuilder(property, modelBuilder) |
There was a problem hiding this comment.
Is property.Builder unavailable here?
ajcvickers
force-pushed
the
YoureJustMyType0525b
branch
2 times, most recently
from
51b813d
to
a694cfe
Compare
smitpatel
approved these changes
May 26, 2017
…itly Issue #8034, possible because of #7166 The idea here is to generate type mappings at model building type and then store them in the model. This allows `property.RelationalAnnotationNames().ColumnType` to always return the store type. The solution is not perfect: - A convention runs when the model is built, which means that ColumnType will remain null during OnModelCreating. This could be changed by lots of conventions that run whenever something that could change the mapping is changed. - Because this is done by convention, and because conventions are not always run (e.g. ModelSnapshot, HistoryTable, using the ModelBuilder directly with an empty convention set) it means sometimes type mappings are not available. However, in the normal application scenario, they will always be available. I will file an issue to look at these things post 2.0.
ajcvickers
force-pushed
the
YoureJustMyType0525b
branch
from
a694cfe
to
e23bd38
Compare
|
Merged |
This was referenced May 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #8034, possible because of #7166
The idea here is to generate type mappings at model building type and then store them in the model. This allows
property.RelationalAnnotationNames().ColumnTypeto always return the store type.The solution is not perfect:
I will file an issue to look at these things post 2.0.