Remove overriding of relational annotations #8512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anpete
approved these changes
May 19, 2017
Part of #7166 Since we now build one model per database provider there is no need to allow relational and provider-specific overrides to exist together in the same model. This means that any relational annotation will always be prefixed with "Relational:" and never with, for example, "SqlServer:". Provider-specific annotations still use the provider prefix. This particularly advantageous for the consumer, since to read, for example, the table name, a consumer only ever needs to read `entityType.Relational().TableName;` instead of having to handle the case where it has been overridden for the current provider. Note: there is other API (e.g. ForSqlServerTableName) than can also be removed; that will be part of another PR.
|
😍 It's beautiful |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #7166
Since we now build one model per database provider there is no need to allow relational and provider-specific overrides to exist together in the same model. This means that any relational annotation will always be prefixed with "Relational:" and never with, for example, "SqlServer:". Provider-specific annotations still use the provider prefix.
This particularly advantageous for the consumer, since to read, for example, the table name, a consumer only ever needs to read
entityType.Relational().TableName;instead of having to handle the case where it has been overridden for the current provider.Note: there is other API (e.g. ForSqlServerTableName) than can also be removed; that will be part of another PR.
Breaking change baselines not updated yet.