Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge main into live #10061

Merged
merged 11 commits into from
Jun 25, 2024
Merged

Merge main into live #10061

merged 11 commits into from
Jun 25, 2024

Conversation

dotnet-policy-service[bot]
Copy link
Contributor

Please don't squash-merge this PR.

kevincathcart-cas and others added 11 commits June 18, 2024 13:47
@kevincathcart-cas
Clarify null name for IOptions related types
cdd065e
@gewarren
fix try.net links (#10048)
c12615d
@albert-du
F# snippets (#10049)
fca2b36
@albert-du
F# snippets for Complex (#10052)
497baea
@albert-du
F# snippets for System.Diagnostics.Process (#10053)
2e09bef
@albert-du
F# snippets for Dictionary<TKey,TValue> (#10056)
a8d0cee 
* constructor

* remainder

* Remove empty snippet reference breaking build

This is a weird one, snippet32 is completely empty.

It's close curly braces for C# and VB
@albert-du
F# snippets for HashSet<T> (#10055)
0d937b8
@albert-du
F# snippets for ComparerT (#10054)
3bff60e
@tarekgh @gewarren
Apply suggestions from code review
15f926f 
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@tarekgh
Merge pull request #10038 from kevincathcart-cas/null-name
8711385 
Clarify null name for IOptions related types
@elinor-fung @jkotas
Update AssesmblyBuilder.DefineDynamicModule to call out that .NET Cor…
d6d38e4 
…e/5+ only supports one module per assembly (#10057)

* Update AssesmblyBuilder.DefineDynamicModule to call out that .NET Core/5+ only supports one module per assembly

* Update xml/System.Reflection.Emit/AssemblyBuilder.xml

Co-authored-by: Jan Kotas <jkotas@microsoft.com>

---------

Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable. label Jun 25, 2024
@learn-build-service-prod Learn Build Service (PROD)
Copy link

Learn Build status updates of commit d6d38e4:

✅ Validation status: passed

File Status Preview URL Details
includes/csharp-interactive-with-utc-note.md ✅Succeeded View
snippets/fsharp/System.Collections.Generic/ComparerT/Overview/fs.fsproj ✅Succeeded
snippets/fsharp/System.Collections.Generic/ComparerT/Overview/program.fs ✅Succeeded View
snippets/fsharp/System.Collections.Generic/DictionaryTKey,TValue/.ctor/fs.fsproj ✅Succeeded
snippets/fsharp/System.Collections.Generic/DictionaryTKey,TValue/.ctor/source.fs ✅Succeeded View
snippets/fsharp/System.Collections.Generic/DictionaryTKey,TValue/.ctor/source1.fs ✅Succeeded View
snippets/fsharp/System.Collections.Generic/DictionaryTKey,TValue/.ctor/source2.fs ✅Succeeded View
snippets/fsharp/System.Collections.Generic/DictionaryTKey,TValue/.ctor/source3.fs ✅Succeeded View
snippets/fsharp/System.Collections.Generic/DictionaryTKey,TValue/.ctor/source4.fs ✅Succeeded View
snippets/fsharp/System.Collections.Generic/DictionaryTKey,TValue/Overview/fs.fsproj ✅Succeeded
snippets/fsharp/System.Collections.Generic/DictionaryTKey,TValue/Overview/source.fs ✅Succeeded View
snippets/fsharp/System.Collections.Generic/DictionaryTKey,TValue/Overview/source2.fs ✅Succeeded View
snippets/fsharp/System.Collections.Generic/DictionaryTKey,TValue/System.Collections.IDictionary.Add/fs.fsproj ✅Succeeded
snippets/fsharp/System.Collections.Generic/DictionaryTKey,TValue/System.Collections.IDictionary.Add/source.fs ✅Succeeded View
snippets/fsharp/System.Collections.Generic/HashSetT/.ctor/fs.fsproj ✅Succeeded
snippets/fsharp/System.Collections.Generic/HashSetT/.ctor/Program.fs ✅Succeeded View
snippets/fsharp/System.Collections.Generic/HashSetT/.ctor/source2.fs ✅Succeeded View
snippets/fsharp/System.Collections.Generic/HashSetT/Clear/fs.fsproj ✅Succeeded
snippets/fsharp/System.Collections.Generic/HashSetT/Clear/Program.fs ✅Succeeded View
snippets/fsharp/System.Collections.Generic/HashSetT/Contains/fs.fsproj ✅Succeeded
snippets/fsharp/System.Collections.Generic/HashSetT/Contains/Program.fs ✅Succeeded View
snippets/fsharp/System.Collections.Generic/HashSetT/IsProperSubsetOf/fs.fsproj ✅Succeeded
snippets/fsharp/System.Collections.Generic/HashSetT/IsProperSubsetOf/Program.fs ✅Succeeded View
snippets/fsharp/System.Collections.Generic/HashSetT/Overview/fs.fsproj ✅Succeeded
snippets/fsharp/System.Collections.Generic/HashSetT/Overview/Program.fs ✅Succeeded View

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.

For any questions, please:

@dotnet-policy-service dotnet-policy-service bot merged commit b5d74a7 into live Jun 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable. :octocat: auto-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kevincathcart-cas @gewarren @albert-du @tarekgh @elinor-fung