-
Notifications
You must be signed in to change notification settings - Fork 854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow custom alert types #8735
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #8735 +/- ##
==========================================
+ Coverage 76.91% 76.96% +0.05%
==========================================
Files 606 606
Lines 25065 25062 -3
==========================================
+ Hits 19278 19290 +12
+ Misses 5787 5772 -15
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The use of token.json in templates doesn't seem to be documented.
Allow custom alerts with the
build.markdownEngineProperties.alerts
property indocfx.json
. The key specifies the markdown keyword without the surrounding[!
,]
symbols. The value is the CSS class names.Alert titles are by default the alert keyword in upper case and can be overridden in
token.json
for localization and other purposes.We choose this approach over the
>[!TIP](a title)
syntax because:fixes #7939
fixes #8391
fixes #6268