Add KeepAliveTimeout support to WebSocketMiddleware #57293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrennanConroy
added
feature-websockets
BrennanConroy
requested review from
halter73,
JamesNK,
mgravell and
captainsafia
as code owners
dotnet-policy-service
bot
added
the
area-networking
amcasey
approved these changes
Aug 12, 2024
halter73
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #57072
Feature added recently in dotnet/runtime#105841
Replaced workaround from #48892.
ServerWebSocket->AbortStream. Solves the same issue but in a different way. This is verified by the testWebSocket_Abort_Interrupts_Pending_ReceiveAsyncThe
AbortStreamworkaround handles the background keep alive whichServerWebSocketdid not. The old workaround only worked when someone called Abort on our websocket impl (ServerWebSocket), which can only happen in user code. With the addition of an abort call from inside the runtimes websocket impl, ourServerWebSocket.Abortfunction would never be called for keep alive timeouts.