Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dotnet SDK to latest published #34854

Closed
wants to merge 1 commit into from

Conversation

MattGal
Copy link
Member

@MattGal MattGal commented Jul 29, 2021

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable. (N/a : updating global.json)
  • You've included inline docs for your change, where applicable. (N/A)
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue. (https://github.com/dotnet/core-eng/issues/13691)

PR Title
Update dotnet SDK to latest published

PR Description
This change brings an up update to take a threading fix that could improve the symptoms of https://github.com/dotnet/core-eng/issues/13691.

See issue for details; this is not necessarily the definitive fix, but something we need to try as the available data points to this as a likely culprit.

I'm making the same PR simultaneously in arcade, runtime, and aspnetcore in an effort to expedite the fix (if this is the fix) as well as exercise package restore in the places this is hitting most.

@MattGal MattGal requested a review from a team as a code owner July 29, 2021 20:26
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jul 29, 2021
@Pilchie
Copy link
Member

Pilchie commented Jul 29, 2021

See #34819, where I think this is already happening. Ping @JunTaoLuo.

@MattGal
Copy link
Member Author

MattGal commented Jul 29, 2021

See #34819, where I think this is already happening. Ping @JunTaoLuo.

Awesome, not trying to step on @JunTaoLuo 's toes or anything. I'll let this finish (so I can see all the restore-from-azdo-public-feeds' outcomes) then close without merging.

@JunTaoLuo
Copy link
Contributor

FYI, we should be ready to merge grpc/grpc-dotnet#1352 very soon.

@MattGal
Copy link
Member Author

MattGal commented Jul 29, 2021

FYI, we should be ready to merge grpc/grpc-dotnet#1352 very soon.

Thanks @JunTaoLuo , I'll close this now. No repros of restore failure on the logs I noted.

@MattGal MattGal closed this Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants