Stop "mask" button from jumping on mouse enter #5799
+11
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In details views, we show sensitive values as masked by default. The user has to click a button to show them on screen. This prevents accidentally revealing secrets to onlookers. The mask button is visible for any sensitive value. There is also a menu button, that opens a popup to allow copying and visualizing the value. This button is only displayed when the mouse hovers over the row in the name/value grid. Previously, these were (in order): - Mask button (always visible) - Menu button (visible on hover) Because these were right-aligned, the mask button would be pushed left to make space for the menu button on house hover. To the user who wanted to toggle a row's mask status, the button they want to press would jump to the left just as the mouse got close. This is surprising and a bit annoying. This change reorders the buttons so that nothing moves on screen when the mouse hovers over the row.
JamesNK
approved these changes
Sep 20, 2024
3 tasks
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Sep 20, 2024
Open
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In details views, we show sensitive values as masked by default. The user has to click a button to show them on screen. This prevents accidentally revealing secrets to onlookers.
The mask button is visible for any sensitive value.
There is also a menu button, that opens a popup to allow copying and visualizing the value. This button is only displayed when the mouse hovers over the row in the name/value grid.
Previously, these were (in order):
Because these were right-aligned, the mask button would be pushed left to make space for the menu button on house hover.
To the user who wanted to toggle a row's mask status, the button they want to press would jump to the left just as the mouse got close. This is surprising and a bit annoying.
This change reorders the buttons so that nothing moves on screen when the mouse hovers over the row.
Before
After
Checklist
<remarks />and<code />elements on your triple slash comments?Microsoft Reviewers: Open in CodeFlow