-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add authentication (username & password) to AddMongoDB #5788
Open
eerhardt
wants to merge
27
commits into
dotnet:main
Choose a base branch
from
eerhardt:MongoDBAuth
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+188
−30
Open
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
8470f27
Add authentication (username & password) to AddMongoDB as optional pa…
Crazyht 563d5ad
Merge branch 'dotnet:main' into main
Crazyht ba0b659
Fix Test for ManifestGeneration by adding passord to config (with val…
Crazyht a4c621d
Merge branch 'main' of https://github.com/Crazyht/aspire
Crazyht 4371472
Merge branch 'dotnet:main' into main
Crazyht 67354be
Remove Uri.DataEncode call
Crazyht 0249def
Merge branch 'main' of https://github.com/Crazyht/aspire
Crazyht 0df7842
Fix test on manifest test after removing EscapeDataString
Crazyht a78049f
Merge branch 'dotnet:main' into main
Crazyht bdee17d
Add overload to avoid breaking change according to discussion on PR
Crazyht 80deb50
Add overload to MongoDBServerResource to avoid breaking changes
Crazyht e66a4f4
Remove special character in password generation as for now we can't e…
Crazyht 92fc5d4
adapt mongo password manifest to include special false
Crazyht cb0c788
Add authentication mechanism with default to SCRAM-SHA-256 & reformat…
Crazyht a31c314
Merge branch 'dotnet:main' into main
Crazyht 66e5f58
Change ConnectionString part to internal
Crazyht 77fea15
Merge branch 'main' of https://github.com/Crazyht/aspire
Crazyht 549a251
Update tests/testproject/TestProject.AppHost/TestProgram.cs
Crazyht ddc38f2
Merge branch 'dotnet:main' into main
Crazyht 4536526
Apply review comments
Crazyht 94f40f8
Merge branch 'main' of https://github.com/Crazyht/aspire
Crazyht 34bfcf3
Merge branch 'dotnet:main' into main
Crazyht 5cb8399
Merge conflit from upstream
Crazyht fe099e0
Apply eerhardt review
Crazyht f4d80c2
Merge remote-tracking branch 'upstream/main'
Crazyht 5d27ad5
Merge remote-tracking branch 'upstream/main' into Crazyht/main
eerhardt 5598874
Fix tests and minor code refactoring
eerhardt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,6 @@ | ||
#nullable enable | ||
Aspire.Hosting.ApplicationModel.MongoDBServerResource.MongoDBServerResource(string! name, Aspire.Hosting.ApplicationModel.ParameterResource? userNameParameter, Aspire.Hosting.ApplicationModel.ParameterResource? passwordParameter) -> void | ||
Aspire.Hosting.ApplicationModel.MongoDBServerResource.PasswordParameter.get -> Aspire.Hosting.ApplicationModel.ParameterResource? | ||
Aspire.Hosting.ApplicationModel.MongoDBServerResource.UserNameParameter.get -> Aspire.Hosting.ApplicationModel.ParameterResource? | ||
static Aspire.Hosting.MongoDBBuilderExtensions.AddMongoDB(this Aspire.Hosting.IDistributedApplicationBuilder! builder, string! name, int? port = null, Aspire.Hosting.ApplicationModel.IResourceBuilder<Aspire.Hosting.ApplicationModel.ParameterResource!>? userName = null, Aspire.Hosting.ApplicationModel.IResourceBuilder<Aspire.Hosting.ApplicationModel.ParameterResource!>? password = null) -> Aspire.Hosting.ApplicationModel.IResourceBuilder<Aspire.Hosting.ApplicationModel.MongoDBServerResource!>! | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't love this pattern. We have a ReferenceExpressionBuilder that could clean up some of this I think. We could have a single method that took a builder and some arguments and returned an expression.