implemented conditional OuterLoopAttribute

[pavelsavara]

Fixes #7368

Use case: I'm adding test echo server to xharness, so that platforms which use xharness could be moved to innerloop.

[riarenas]

Adding some people who are better versed in xunit to discuss whether this is the right way to go.

@ViktorHofer @alexperovich @akoeplinger

[ViktorHofer]

Why can't you use two attributes instead? If I'm not mistaken, that should already be possible today:

[Outerloop]
[ConditionalFact(...)]

[pavelsavara]

@ViktorHofer the use case is other way around. I want the test to not be in outerloop category for some platforms. So that it would run in inner loop.

[akoeplinger]

Would it make sense to add a condition overload to the constructor of the main OuterLoop type instead, rather than making a new type?

[pavelsavara]

It's surely possible. I actually implemented that first and then changed my mind. But I don't have strong preference.

[akoeplinger]

Ok, I don't have a strong preference either way too :)

[ViktorHofer]

I would prefer to avoid the additional type, especially as its name is a bit confusing.

[safern]

I would prefer to avoid the additional type, especially as its name is a bit confusing.

Agreed. I think it would be better to just use the current OuterloopAttribute, just how we did with ActiveIssue.