Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Add exe files to API Scan #8617

Merged
merged 8 commits into from
Jan 10, 2024
Merged

[ci] Add exe files to API Scan #8617

merged 8 commits into from
Jan 10, 2024

Conversation

pjcollins
Copy link
Member

@pjcollins pjcollins commented Jan 8, 2024

The API Scan job added in commit a10aa38 accidentally excluded some
of our xamarin-android-binutils artifacts. The job has been fixed to
scan the EXE files (and corresponding symbols) that were previously
skipped. The latest scan results appear to be consistent with what was
being reported through VS scans, and we can continue working through
these issues:

1. ApiScan Error missingsymbols - File: aapt2.exe.
Tool: ApiScan: Rule: missingsymbols (Missing Symbols)

2. ApiScan Error documentationnotfound - File: aapt2.exe.
Tool: ApiScan: Rule: documentationnotfound (Documentation Not Found).

3. ApiScan Error improperfileformat - File: as.exe.
Tool: ApiScan: Rule: improperfileformat (Improper File Format).

4. ApiScan Error missingsymbols - File: ld.exe.
Tool: ApiScan: Rule: missingsymbols (Missing Symbols).

5. ApiScan Error improperfileformat - File: libzipsharpnative-3-0.dll.
Tool: ApiScan: Rule: improperfileformat (Improper File Format).

6. ApiScan Error improperfileformat - File: llc.exe.
Tool: ApiScan: Rule: improperfileformat (Improper File Format).

7. ApiScan Error improperfileformat - File: llvm-mc.exe.
Tool: ApiScan: Rule: improperfileformat (Improper File Format).

8. ApiScan Error missingsymbols - File: llvm-strip.exe.
Tool: ApiScan: Rule: missingsymbols (Missing Symbols).

@pjcollins pjcollins marked this pull request as ready for review January 10, 2024 20:56
@pjcollins pjcollins requested a review from jpobst January 10, 2024 20:56
@pjcollins pjcollins merged commit de9d6c8 into main Jan 10, 2024
44 of 49 checks passed
@pjcollins pjcollins deleted the dev/pjc/apiscanmit branch January 10, 2024 23:28
grendello added a commit that referenced this pull request Jan 11, 2024
* main:
  [ci] Add exe files to API Scan (#8617)
  [Microsoft.Android.Templates] New files should open editor (#8623)
  [Xamarin.Android.Build.Tasks] remove `@(_AndroidAssemblySkipCases)` (#8622)
@github-actions github-actions bot locked and limited conversation to collaborators Feb 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants