-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mono.Android] API-UpsideDownCake Beta 1 #7980
Conversation
7f2f400
to
836f3fc
Compare
@@ -78,7 +78,6 @@ | |||
5, android.bluetooth,BluetoothClass,getMajorDeviceClass,return,Android.Bluetooth.MajorDeviceClass | |||
5, android.bluetooth,BluetoothClass,hasService,service,Android.Bluetooth.ServiceClass | |||
5, android.bluetooth,BluetoothDevice,getBondState,return,Android.Bluetooth.Bond | |||
0, android.content,Context,bindService,flags,Android.Content.Bind |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume that these removals were made because they were "duplicative" of the metadata
additions, e.g.
<attr
path="/api/package[@name='android.content']/class[@name='Context']/method[@name='bindService' and count(parameter)=3 and parameter[1][@type='android.content.Intent'] and parameter[2][@type='android.content.ServiceConnection'] and parameter[3][@type='int']]/parameter[@name='flags']"
name="enumType">Android.Content.Bind</attr>
Is my assumption correct?
Is there a reason to prefer the metadata
approach vs. the methodmap.csv
approach?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad, the metadata
lines were placed in a section that describes why they are used, but that doesn't show up in the PR diff: https://github.com/xamarin/xamarin-android/pull/7980/files#diff-dbf22a7169e51cdd444864d89c196068bd583e320486401e528bf3b28917569cL1670-L1672
<!-- We have 2 methods with the same name and the same parameter name. One needs to be enumified but not the other.
Our methodmap.csv isn't capable of only choosing 1 of the methods, so it sets them both as the enum, making both have the
same signature. So we are going to set the enum transformation here instead, where we can specify a path that only affects a single method. -->
* main: [Xamarin.Android.Build.Tasks] enable ForceInterpretedInvoke switch (dotnet#7972) [Mono.Android] Bind API-UpsideDownCake Beta 1 (dotnet#7980) Bump to xamarin/xamarin-android-tools/main@8bc07503 (dotnet#7863) [automation] Add 'xaSourcePath' to yaml so they can be used from monodroid. (dotnet#7978) Bump to dotnet/installer@16c10f8115 8.0.100-preview.4.23218.1 (dotnet#7969) [docs] Add UnitTest.md (dotnet#7877) [ci] Suppress fork PR build warnings (dotnet#7973) [Xamarin.Android.Build.Tasks] Bump ZipFlushFilesLimit (dotnet#7957) Bump to dotnet/installer@3ca7ad1c79 8.0.100-preview.4.23211.1 (dotnet#7946) [CI] Allow passing xamarin-android checkout dir to nested templates. (dotnet#7961) [Xamarin.Android.Build.Tasks] Fix `-int.ToString()` for locales (dotnet#7941) [ci] Automatically retry failed apk-instrumentation tests. (dotnet#7963)
Context: https://developer.android.com/about/versions/14
Context: https://android-developers.googleblog.com/2023/04/android-14-beta-1.html
Android 14 Developer Preview 1 has been released. The Android 14
Developer Preview Program Overview Timeline and updates section
suggests the following timeline: