Skip to content

Commit

Permalink
[tests] stop using bintray URLs (#5872)
Browse files Browse the repository at this point in the history
Context: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=4690182&view=ms.vss-test-web.build-test-results-tab

The `BuildTest.Desugar()` test is failing on CI with:

    System.Net.WebException : The remote server returned an error: (403) Forbidden.

Even using the latest URLs here, the download gives me a login prompt
in the browser:

    https://mvnrepository.com/artifact/com.twitter.sdk.android/twitter-core/3.3.0
    https://repo.spring.io/libs-release/com/twitter/sdk/android/twitter-core/3.3.0/twitter-core-3.3.0.aar

I just removed the usage of this `.aar` file in the `Desugar()` test,
since there seem to be sufficient `.aar` files used in the test.

I also updated a few other URLs that were using `bintray.com`, because
they may eventually stop working.
  • Loading branch information
jonathanpeppers authored Apr 26, 2021
1 parent b0eb1a3 commit eac74eb
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ public void BuildAarBindigLibraryWithNuGetPackageOfJar (string classParser)
};
proj.PackageReferences.Add (KnownPackages.AndroidSupportV4_27_0_2_1);
proj.Jars.Add (new AndroidItem.LibraryProjectZip ("Jars\\android-crop-1.0.1.aar") {
WebContent = "https://jcenter.bintray.com/com/soundcloud/android/android-crop/1.0.1/android-crop-1.0.1.aar"
WebContent = "https://repo1.maven.org/maven2/com/soundcloud/android/android-crop/1.0.1/android-crop-1.0.1.aar"
});
proj.MetadataXml = @"
<metadata>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3299,10 +3299,6 @@ public override void OnReceive(Context context, Intent intent) { }
proj.OtherBuildItems.Add (new BuildItem ("AndroidJavaLibrary", "gson-2.7.jar") {
WebContent = "https://repo1.maven.org/maven2/com/google/code/gson/gson/2.7/gson-2.7.jar"
});
//Twitter SDK https://bintray.com/twitteross/twitterkit/twitter-core/3.3.0
proj.OtherBuildItems.Add (new BuildItem ("AndroidAarLibrary", "twitter-core-3.3.0.aar") {
WebContent = "https://dl.bintray.com/twitteross/twitterkit/com/twitter/sdk/android/twitter-core/3.3.0/twitter-core-3.3.0.aar",
});
/* The source is simple:
*
public class Lambda
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ public void GetExtraLibraryLocationsForDesigner ()
WebContent = $"https://repo1.maven.org/maven2/com/google/code/gson/gson/2.7/{jar}"
});
proj.OtherBuildItems.Add (new AndroidItem.AndroidAarLibrary ("android-crop-1.0.1.aar") {
WebContent = "https://jcenter.bintray.com/com/soundcloud/android/android-crop/1.0.1/android-crop-1.0.1.aar"
WebContent = "https://repo1.maven.org/maven2/com/soundcloud/android/android-crop/1.0.1/android-crop-1.0.1.aar"
});
// Each NuGet package and AAR file are in libraryprojectimports.cache, AndroidJavaSource is not
int libraryProjectImportsJars = 14;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -838,7 +838,7 @@ public void ResolveLibraryProjectImports ([Values (true, false)] bool useAapt2)

// Add a new AAR file to the project
var aar = new AndroidItem.AndroidAarLibrary ("Jars\\android-crop-1.0.1.aar") {
WebContent = "https://jcenter.bintray.com/com/soundcloud/android/android-crop/1.0.1/android-crop-1.0.1.aar"
WebContent = "https://repo1.maven.org/maven2/com/soundcloud/android/android-crop/1.0.1/android-crop-1.0.1.aar"
};
proj.OtherBuildItems.Add (aar);

Expand Down

0 comments on commit eac74eb

Please sign in to comment.