Skip to content

Commit

Permalink
[tests] BuildAfterUpgradingNuGet should be NonParallelizable (#2588)
Browse files Browse the repository at this point in the history
Context: http://build.devdiv.io/2307677

The `BuildTest.BuildAfterUpgradingNuGet()` test occasionally fails:

	Xamarin.ProjectTools.FailedBuildException : Build failure: UnnamedProject.csprojBuild log recorded

Reviewing the log, we are getting:

	NuGet.targets(114,5): The process cannot access the file 'xamarin.forms.2.3.4.231.nupkg' because it is being used by another process.

It looks like two NuGet restores in parallel are stepping on each
other.

This has happened a couple builds in a row, so I think it is worth
adding the `[NonParallelizable]` attribute on this test.
  • Loading branch information
jonathanpeppers authored and jonpryor committed Jan 4, 2019
1 parent 9a1c662 commit a422d5d
Showing 1 changed file with 1 addition and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -2525,6 +2525,7 @@ public void BuildAfterAddingNuget ()

//This test validates the _CleanIntermediateIfNuGetsChange target
[Test]
[NonParallelizable]
public void BuildAfterUpgradingNuget ([Values (false, true)] bool usePackageReference)
{
var proj = new XamarinAndroidApplicationProject ();
Expand Down

0 comments on commit a422d5d

Please sign in to comment.