Merged DbConnectionClosed, DbConnectionFactory, SqlAuthenticationProviderManager #2410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
David-Engel
approved these changes
Mar 29, 2024
|
@edwardneal Can you address the conflicts, please? |
|
Thanks @DavoudEshtehari, I've addressed the conflicts. CI is effectively done - there are a few test failures, which seem to be unrelated. |
DavoudEshtehari
added
the
➕ Code Health
|
One more conflict after merging your PR. ;) |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2410 +/- ##
==========================================
- Coverage 72.03% 72.02% -0.01%
==========================================
Files 305 299 -6
Lines 61804 61394 -410
==========================================
- Hits 44522 44221 -301
+ Misses 17282 17173 -109
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Thanks - re-merged. The test failures remain unrelated |
src/Microsoft.Data.SqlClient/src/Microsoft/Data/ProviderBase/DbConnectionFactory.cs
Show resolved
Hide resolved
DavoudEshtehari
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #1261.
This merges the three classes above. DbConnectionFactory has a few references to the metric reporting processes (which are different between .NET Core and Framework) and I've hidden these behind conditional compilation.