-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement | Add explicit version for major .NET version dependencies #2303
Conversation
@David-Engel Wonder if it is time to abandon support for netstandard2.0 and netstandard2.1 ? Let me know and I will be happy to do a PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2303 +/- ##
==========================================
+ Coverage 72.49% 72.63% +0.13%
==========================================
Files 310 310
Lines 61868 62125 +257
==========================================
+ Hits 44854 45123 +269
+ Misses 17014 17002 -12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@DavoudEshtehari Should I be concerned about the test failures? |
@ErikEJ , I've re-run the failed Pipeline tests, and all the tests have passed. It's on the final step Merge Code, and I usually never see any problems when it get's that far. Thank-you for making sure the build goes green. Cheers. |
src/Microsoft.Data.SqlClient/netcore/src/Microsoft.Data.SqlClient.csproj
Outdated
Show resolved
Hide resolved
That's a major version bump task. I think we'll go to 6.0 after 5.2, so it's something we'll consider. |
src/Microsoft.Data.SqlClient/netcore/src/Microsoft.Data.SqlClient.csproj
Outdated
Show resolved
Hide resolved
LGTM, only the naming could be improved to something more appropriate identifying net8 and upper. Net6 will be out of support by the end of this year and this will become the only version props for the driver. We can adjust the name to version.props on that time. |
@JRahnama any suggestions for a better name? Versioncurrent.props ? Version latest.props? |
We can either revers the order and set Net8 as the default version.props and add net6version.props for net6 or just change the name to Version8Compatible or something similar to it. |
@JRahnama I renamed the props file to VersionsNet8OrLater.props |
/azurepipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
I have also removed explicit references in test projects, they will just use the transitive reference