Extend DateOnly/TimeOnly support to include DataTable as structured parameter #2258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arameter Also makes some tests run on machines in winter outside UTC time zones :-D fixes dotnet#2209
ErikEJ
commented
Dec 6, 2023
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/Server/MetadataUtilsSmi.cs
Show resolved
Hide resolved
ErikEJ
commented
Dec 6, 2023
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/Server/MetadataUtilsSmi.cs
Show resolved
Hide resolved
ErikEJ
commented
Dec 6, 2023
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/Server/ValueUtilsSmi.cs
Show resolved
Hide resolved
ErikEJ
commented
Dec 6, 2023
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/Server/ValueUtilsSmi.cs
Show resolved
Hide resolved
ErikEJ
commented
Dec 6, 2023
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2258 +/- ##
==========================================
+ Coverage 72.58% 74.14% +1.55%
==========================================
Files 309 310 +1
Lines 61959 73468 +11509
==========================================
+ Hits 44976 54476 +9500
- Misses 16983 18992 +2009
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@David-Engel @JRahnama Any chance to get this reviewed now? |
David-Engel
approved these changes
Jan 25, 2024
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/Server/MetadataUtilsSmi.cs
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/Server/MetadataUtilsSmi.cs
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/Server/ValueUtilsSmi.cs
Show resolved
Hide resolved
JRahnama
changed the title
|
@David-Engel @JRahnama Is this still on the radar? |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@David-Engel @JRahnama Is this still on the radar? |
DavoudEshtehari
approved these changes
Apr 9, 2024
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/Server/ValueUtilsSmi.cs
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also makes some tests run on machines in winter outside UTC time zones :-D
fixes #2209