-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add | Adding net8 support #2230
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2230 +/- ##
==========================================
- Coverage 72.54% 72.20% -0.35%
==========================================
Files 310 310
Lines 62045 62045
==========================================
- Hits 45011 44799 -212
- Misses 17034 17246 +212
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
In CertificateTest.cs, do we want to clean up this comment as well? |
Everything else looks good to me. |
Basically the API was added in net7, so it could stay the same or I can adjust it to net7 and greater version. |
/azurepipelines run |
Pull request contains merge conflicts. |
tools/specs/add-ons/Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider.nuspec
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/netcore/ref/Microsoft.Data.SqlClient.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlException.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com>
# Conflicts: # src/Microsoft.Data.SqlClient/netcore/ref/Microsoft.Data.SqlClient.cs # src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlException.cs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, waiting for the feedback from the API doc process.
Hopefully with the new downstream vulnerabilities that have been issues, this package will get updated soon. Moving forward, this package should contain multiple builds targeting the currently supported runtimes, so that people installing this package in their apps can get the latest release for the .NET runtime they are targeting. I was SHOCKED to see one of my NuGet packages was resolving references all the way back down to .NET 6, even though I was targeting .NET 8, because of this package. Thanks for your swift attention to getting this resolved! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Replacing Net7 with Net8.0