-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix | Fixing issue for SQL named Instances in Managed SNI using named pipes. #2142
Fix | Fixing issue for SQL named Instances in Managed SNI using named pipes. #2142
Conversation
Codecov ReportAttention:
... and 32 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SNI/SNIProxy.cs
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/InstanceNameTest/InstanceNameTest.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/InstanceNameTest/InstanceNameTest.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SNI/SNIProxy.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SNI/SNIProxy.cs
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/src/Microsoft/Data/Common/AdapterUtil.Windows.cs
Outdated
Show resolved
Hide resolved
…malizedPipePath or _normalizedPipePath whichever worked. Disable platform checking for non-windows but comment that it is for WSL debugging.
…hTest(string instance)
…onfig.default.json. Added NamedPipeSecondaryInstanceTest.
… named instance in UpdateConfig task instead by not setting named instance connection string.
@arellegue are the failures addressed on the pipelines? |
… for running named instance unit test.
…already a named instance test that is using the existing Tcp and Np connection strings.
The CI-SqlClient pipeline is now passing for this PR. The Named Instance Test Job is disabled for now in CI-SqlClient pipeline. It will be enabled once this PR is approved. |
fixes #2113