Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.0.1] Fix | Default UTF8 collation conflict #1799

Merged
merged 1 commit into from
Oct 7, 2022

Conversation

JRahnama
Copy link
Member

@JRahnama JRahnama commented Oct 7, 2022

Backporting #1739.

@codecov
Copy link

codecov bot commented Oct 7, 2022

Codecov Report

Base: 65.47% // Head: 71.38% // Increases project coverage by +5.91% 🎉

Coverage data is based on head (cea2ab4) compared to base (914caf5).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@                Coverage Diff                @@
##           5.0-servicing    #1799      +/-   ##
=================================================
+ Coverage          65.47%   71.38%   +5.91%     
=================================================
  Files                293      293              
  Lines              61385    61384       -1     
=================================================
+ Hits               40189    43821    +3632     
+ Misses             21196    17563    -3633     
Flag Coverage Δ
addons 92.38% <ø> (+92.38%) ⬆️
netcore 74.94% <100.00%> (+5.75%) ⬆️
netfx 69.25% <100.00%> (+5.56%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...core/src/Microsoft/Data/SqlClient/SqlDataReader.cs 72.84% <100.00%> (+1.47%) ⬆️
...c/Microsoft/Data/SqlClient/TdsParserStateObject.cs 81.57% <100.00%> (-0.08%) ⬇️
...etfx/src/Microsoft/Data/SqlClient/SqlDataReader.cs 68.48% <100.00%> (+1.40%) ⬆️
...nt/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs 70.96% <100.00%> (+8.86%) ⬆️
...c/Microsoft/Data/SqlClient/TdsParserStateObject.cs 81.58% <100.00%> (ø)
...osoft/Data/SqlClient/SqlConnectionStringBuilder.cs 88.60% <100.00%> (+0.01%) ⬆️
...re/src/Microsoft/Data/SqlClient/SNI/SNINpHandle.cs 73.77% <0.00%> (-4.92%) ⬇️
.../src/Microsoft/Data/SqlClient/SNI/SNIMarsHandle.cs 87.89% <0.00%> (-4.49%) ⬇️
...crosoft/Data/SqlClient/SqlInternalConnectionTds.cs 67.27% <0.00%> (-0.18%) ⬇️
... and 54 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@JRahnama JRahnama added this to the 5.0.1 milestone Oct 7, 2022
@JRahnama JRahnama merged commit 711b72c into dotnet:5.0-servicing Oct 7, 2022
@JRahnama JRahnama deleted the backport-utf8 branch October 31, 2022 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants