Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release 5.0] Fix Null Reference Exception on assigning null to SqlConnectionStringBuilder.Encrypt #1784

Merged

Conversation

cheenamalhotra
Copy link
Member

Ports #1778 to 5.0-servicing.

@cheenamalhotra cheenamalhotra added this to the 5.0.1 milestone Oct 4, 2022
@codecov
Copy link

codecov bot commented Oct 4, 2022

Codecov Report

Base: 65.47% // Head: 71.79% // Increases project coverage by +6.32% 🎉

Coverage data is based on head (fcd8185) compared to base (914caf5).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@                Coverage Diff                @@
##           5.0-servicing    #1784      +/-   ##
=================================================
+ Coverage          65.47%   71.79%   +6.32%     
=================================================
  Files                293      293              
  Lines              61385    61386       +1     
=================================================
+ Hits               40189    44073    +3884     
+ Misses             21196    17313    -3883     
Flag Coverage Δ
addons 92.38% <ø> (+92.38%) ⬆️
netcore 75.39% <100.00%> (+6.19%) ⬆️
netfx 69.58% <100.00%> (+5.89%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...osoft/Data/SqlClient/SqlConnectionStringBuilder.cs 88.60% <100.00%> (+0.01%) ⬆️
...re/src/Microsoft/Data/SqlClient/SNI/SNINpHandle.cs 73.77% <0.00%> (-4.92%) ⬇️
.../Microsoft/Data/SqlClient/SNI/SNIMarsConnection.cs 76.72% <0.00%> (-0.63%) ⬇️
...crosoft/Data/SqlClient/SqlInternalConnectionTds.cs 72.88% <0.00%> (+0.19%) ⬆️
...rc/Microsoft/Data/ProviderBase/DbConnectionPool.cs 86.36% <0.00%> (+0.29%) ⬆️
...c/Microsoft/Data/SqlClient/SqlClientEventSource.cs 80.13% <0.00%> (+0.34%) ⬆️
...crosoft/Data/SqlClient/SqlInternalConnectionTds.cs 67.97% <0.00%> (+0.52%) ⬆️
...SqlClient/src/Microsoft/Data/SqlClient/SqlEnums.cs 77.37% <0.00%> (+0.63%) ⬆️
.../Data/SqlClient/SqlClientEventSource.NetCoreApp.cs 100.00% <0.00%> (+0.64%) ⬆️
...SqlClient/src/Microsoft/Data/Common/AdapterUtil.cs 68.38% <0.00%> (+0.82%) ⬆️
... and 54 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@David-Engel David-Engel merged commit ee27832 into dotnet:5.0-servicing Oct 5, 2022
@cheenamalhotra cheenamalhotra deleted the cheena/5-0-fix-nre-encrypt branch April 20, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants