Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding TDS8 version for TDSLogin #1657

Merged
merged 12 commits into from
Jul 23, 2022
Merged

Conversation

JRahnama
Copy link
Member

This is addressing TDS8 issue with TDS Login version.
fixes #1652

@codecov
Copy link

codecov bot commented Jun 21, 2022

Codecov Report

Merging #1657 (0e53d99) into main (ff013e4) will decrease coverage by 0.06%.
The diff coverage is 54.54%.

@@            Coverage Diff             @@
##             main    #1657      +/-   ##
==========================================
- Coverage   71.39%   71.32%   -0.07%     
==========================================
  Files         293      293              
  Lines       61368    61382      +14     
==========================================
- Hits        43812    43783      -29     
- Misses      17556    17599      +43     
Flag Coverage Δ
addons 92.38% <ø> (ø)
netcore 74.90% <58.33%> (-0.09%) ⬇️
netfx 69.16% <50.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...SqlClient/src/Microsoft/Data/SqlClient/TdsEnums.cs 92.68% <ø> (ø)
...nt/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs 70.93% <37.50%> (+0.07%) ⬆️
.../netcore/src/Microsoft/Data/SqlClient/TdsParser.cs 73.63% <50.00%> (-0.17%) ⬇️
...crosoft/Data/SqlClient/SqlInternalConnectionTds.cs 73.28% <100.00%> (+0.39%) ⬆️
...crosoft/Data/SqlClient/SqlInternalConnectionTds.cs 67.62% <100.00%> (ø)
...ata/SqlClient/SqlConnectionTimeoutErrorInternal.cs 30.35% <0.00%> (-11.61%) ⬇️
...src/Microsoft/Data/SqlClient/SqlMetadataFactory.cs 81.66% <0.00%> (-10.84%) ⬇️
...re/src/Microsoft/Data/SqlClient/SNI/SNINpHandle.cs 68.85% <0.00%> (-4.92%) ⬇️
...Microsoft/Data/ProviderBase/DbConnectionFactory.cs 17.04% <0.00%> (-3.41%) ⬇️
.../Microsoft/Data/SqlClient/SNI/SNIMarsConnection.cs 76.72% <0.00%> (-0.63%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff013e4...0e53d99. Read the comment docs.

Copy link
Contributor

@David-Engel David-Engel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we also send the version in LOGIN7 (TdsLogin() method)?

@JRahnama
Copy link
Member Author

Just a note that the minor version 0x0005 for SQL server 2022 would be changed to 0 in the next release SQL2022.

@DavoudEshtehari DavoudEshtehari added this to the 5.0.0 milestone Jul 12, 2022
@JRahnama
Copy link
Member Author

for those who are going to test. Please use below query to see related fields.

elect 
ec.connect_time,es.last_request_start_time ,es.session_id, 
(CAST(protocol_version AS BINARY(4))),
es.program_name, es.client_version, ec.protocol_type,ec.protocol_version,
es.client_interface_name,ec.encrypt_option
from sys.dm_exec_sessions as es
inner join sys.dm_exec_connections as ec
        on ec.session_id = es.session_id

@DavoudEshtehari DavoudEshtehari added the 🐛 Bug! Something isn't right ! label Jul 22, 2022
@JRahnama JRahnama merged commit 620cf46 into dotnet:main Jul 23, 2022
@JRahnama JRahnama deleted the fix-TDSLoginAC-TDS8 branch September 29, 2022 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug! Something isn't right !
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Protocol Version for TDS 8.0 connection
3 participants