Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to Shared-MetadataUtilsSmi #1339

Merged
merged 14 commits into from
Mar 9, 2022
Merged

Move to Shared-MetadataUtilsSmi #1339

merged 14 commits into from
Mar 9, 2022

Conversation

Kaur-Parminder
Copy link
Contributor

This is part of #1261 Move the file file common folder.

@Kaur-Parminder Kaur-Parminder marked this pull request as draft October 12, 2021 23:06
@Kaur-Parminder Kaur-Parminder added the ➕ Code Health Changes related to source code improvements label Oct 12, 2021
@Kaur-Parminder Kaur-Parminder added this to the 4.0.0-preview3 milestone Oct 12, 2021
@Kaur-Parminder Kaur-Parminder mentioned this pull request Oct 12, 2021
Open
@Kaur-Parminder Kaur-Parminder marked this pull request as ready for review October 15, 2021 17:00
DavoudEshtehari
DavoudEshtehari reviewed Oct 15, 2021
View reviewed changes
Copy link
Member

@DavoudEshtehari DavoudEshtehari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you include the inline comments in XML summary tags where ever it's applicable, please?

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/Server/MetadataUtilsSmi.cs Outdated Show resolved Hide resolved
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/Server/MetadataUtilsSmi.cs Outdated Show resolved Hide resolved
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/Server/MetadataUtilsSmi.cs Outdated Show resolved Hide resolved
@cheenamalhotra cheenamalhotra removed this from the 4.0.0-preview3 milestone Oct 19, 2021
@JRahnama JRahnama added this to the 5.0.0-preview1 milestone Dec 7, 2021
Kaur-Parminder and others added 3 commits December 24, 2021 11:54
@Kaur-Parminder
Merge branch 'dotnet:main' into CodeMergeMetadataUtilsSmi
8980744
@Kaur-Parminder
reviewer's comment
bf1a6ea 
reviewer's comment
@Kaur-Parminder @DavoudEshtehari
Update src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/Serv…
9330150 
…er/MetadataUtilsSmi.cs

Co-authored-by: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com>
@DavoudEshtehari DavoudEshtehari mentioned this pull request Jan 10, 2022
Merged
@JRahnama
Copy link
Member

JRahnama commented Feb 4, 2022

Can you address the conflicts please that we can merge the code

@Kaur-Parminder
Copy link
Contributor Author

Can you address the conflicts please that we can merge the code

Done

@Kaur-Parminder Kaur-Parminder merged commit 1a7cbb2 into dotnet:main Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcheunglci lcheunglci lcheunglci left review comments

@johnnypham johnnypham johnnypham approved these changes

@JRahnama JRahnama JRahnama approved these changes

@DavoudEshtehari DavoudEshtehari DavoudEshtehari approved these changes

Assignees
No one assigned
Labels
➕ Code Health Changes related to source code improvements
Projects
None yet
Milestone
5.0.0-preview1
Development

Successfully merging this pull request may close these issues.
6 participants
@Kaur-Parminder @JRahnama @johnnypham @lcheunglci @DavoudEshtehari @cheenamalhotra