Fix parsing of ESLint reports in jest-junit format #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@phjardas , @KholdStare, @tdabinskas, I ran into a similar issue as yourselves where there were features that I needed from this project and looked like it wasn't being updated any time soon, so I took the initiative to fork the project myself and build the enhancements into it with a colleague. https://github.com/phoenix-actions/test-reporting/ |
jozefizso
force-pushed
the
fix-jest-junit-missing-time
branch
2 times, most recently
from
066f6b1
to
9b4d5e8
Compare
|
@jozefizso, is it ok for you ? |
jozefizso
approved these changes
Jan 12, 2024
The [ESLint junit formatter](https://www.npmjs.com/package/eslint-junit) does not include a total time attribute for the root `<testsuites>` element.
jozefizso
force-pushed
the
fix-jest-junit-missing-time
branch
from
9b4d5e8
to
7befe80
Compare
|
Hi @phjardas, thanks for this bug fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ESLint junit formatter does not include a total time attribute for the root
<testsuites>element.This PR makes the parser a little bit more lenient to accept
testsuiteselements without any attributes at all.